Skip to content

Simplify codegen for hl.grid #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

Simplify codegen for hl.grid #210

merged 1 commit into from
Jun 21, 2025

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jun 21, 2025 •
edited
Loading

@jansel
Simplify codegen for hl.grid
d4089f5 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
jansel added a commit that referenced this pull request Jun 21, 2025
@jansel
Simplify codegen for hl.grid
07353f5 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
@jansel jansel force-pushed the jansel/stack/60 branch from 9f44b61 to 437223e Compare June 21, 2025 00:06
@jansel jansel force-pushed the jansel/stack/61 branch from ca8ee70 to 07353f5 Compare June 21, 2025 00:06
This was referenced Jun 21, 2025
Merged
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 21, 2025
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 00:15
jansel added a commit that referenced this pull request Jun 21, 2025
@jansel
Simplify codegen for hl.grid
61c7c18 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
@jansel jansel force-pushed the jansel/stack/61 branch from 07353f5 to 61c7c18 Compare June 21, 2025 00:15
@jansel jansel changed the base branch from main to jansel/stack/60 June 21, 2025 00:15
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 04:18
@jansel jansel changed the base branch from main to jansel/stack/60 June 21, 2025 04:18
@jansel jansel mentioned this pull request Jun 21, 2025
Merged
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 05:02
@jansel jansel changed the base branch from main to jansel/stack/60 June 21, 2025 05:02
@jansel jansel mentioned this pull request Jun 21, 2025
Merged
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 14:12
@jansel jansel changed the base branch from main to jansel/stack/60 June 21, 2025 14:13
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 15:06
@jansel jansel changed the base branch from main to jansel/stack/60 June 21, 2025 15:07
@jansel jansel mentioned this pull request Jun 21, 2025
Merged
@jansel jansel requested a review from yf225 June 21, 2025 16:59
@jansel jansel force-pushed the jansel/stack/60 branch from 437223e to 09e550f Compare June 21, 2025 18:11
jansel added a commit that referenced this pull request Jun 21, 2025
@jansel
Simplify codegen for hl.grid
e95888a 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
@jansel jansel force-pushed the jansel/stack/61 branch from 61c7c18 to e95888a Compare June 21, 2025 18:11
@jansel jansel force-pushed the jansel/stack/60 branch from 09e550f to 8405b79 Compare June 21, 2025 18:12
jansel added a commit that referenced this pull request Jun 21, 2025
@jansel
Simplify codegen for hl.grid
9ad222e 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
@jansel jansel force-pushed the jansel/stack/61 branch from e95888a to 9ad222e Compare June 21, 2025 18:13
@jansel jansel force-pushed the jansel/stack/60 branch from 8405b79 to d1ef805 Compare June 21, 2025 18:14
jansel added a commit that referenced this pull request Jun 21, 2025
@jansel
Simplify codegen for hl.grid
89676af 
This makes codegen for grids go down the standard SymInt codegen path.

stack-info: PR: #210, branch: jansel/stack/61
@jansel jansel force-pushed the jansel/stack/61 branch 2 times, most recently from 89676af to d4089f5 Compare June 21, 2025 18:16
@jansel jansel changed the base branch from jansel/stack/60 to main June 21, 2025 18:16
@jansel jansel merged commit 095235b into main Jun 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yf225 yf225 yf225 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jansel @yf225 @facebook-github-bot