Support range() loops (alias for hl.grid) #212
Merged
+128
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2025
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 21, 2025
yf225
approved these changes
Jun 21, 2025
oulgen
reviewed
Jun 21, 2025
| @@ -118,7 +118,7 @@ def fn(x: torch.Tensor) -> torch.Tensor: | |||
| batch = x.size(0) | |||
| out = x.new_empty(batch) | |||
| for tile_batch in hl.tile(batch): | |||
| for i in range(10): | |||
| for i in [1, 2, 3]: | |||
There was a problem hiding this comment.
does this mean the literal [1,2,3] is not supported? should we support it?
There was a problem hiding this comment.
Correct, it is not supported. We could support it by unrolling the loop, not sure if it is allowd in Triton.
oulgen
approved these changes
Jun 21, 2025
jansel
force-pushed
the
jansel/stack/63
branch
2 times, most recently
from
90e4ae7 to
e56d028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Support range() loops (alias for hl.grid)
Fixes #207